[PR] Adding drag n drop and index-based reordering #345

LuchoTurtle · 2023-03-31T09:55:12Z

closes #145

This PR is not-completed. It was a quick attempt to get drag-n-drop working on the mvp by following the work done by @SimonLab and implementing a simple way of sorting the items through an index field within the schema.
Every time an item is dropped to a new index, the indexes of the other items would be updated accordingly.
This is done by updating the index of the items before the item with the new index, as well as the ones after the new index.

This is done by using update_all.

Additionally, this PR tries to implement the changes that @SimonLab made in https://github.com/dwyl/learn-alpine.js/blob/main/drag-and-drop.md (through dwyl/learn-alpine.js#5) but I can't seem to get it to work properly (show the yellow highlight change as I drag an item through the list).

Since the focus is on https://github.com/dwyl/app, it makes sense to tackle #145 there instead of the MVP.

I'm pushing this PR because it might have relevant code to tackle this issue later when we'll eventually implement this strategy on the API, which the Flutter app will connect to.

…r adding a new item. #145

…ase. #145

codecov · 2023-04-03T18:20:30Z

Codecov Report

Merging #345 (6362525) into main (699e6cc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #345   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        22    +2     
  Lines          524       599   +75     
=========================================
+ Hits           524       599   +75

Files Changed	Coverage Δ
lib/app_web/controllers/auth_controller.ex	`100.00% <ø> (ø)`
lib/app/cid.ex	`100.00% <100.00%> (ø)`
lib/app/item.ex	`100.00% <100.00%> (ø)`
lib/app/list.ex	`100.00% <100.00%> (ø)`
lib/app_web/controllers/init_controller.ex	`100.00% <100.00%> (ø)`
lib/app_web/live/app_live.ex	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

LuchoTurtle · 2023-04-04T12:21:30Z

This should be reviewable.

nelsonic · 2023-04-09T19:41:56Z

reading through the PR now and noticed that the stats section of the README.md is blank:
https://github.com/dwyl/mvp/blob/drag-drop_fix%23145/BUILDIT.md#14-adding-a-dashboard-to-track-metrics

🤷‍♂️

LuchoTurtle · 2023-04-09T19:51:34Z

Probably there was a commit that erased the work I had done because I definitely wrote those sections.
You can see those in https://github.com/dwyl/mvp/blob/faba54760ab0435653434aec7c9f801096fbbd8b/BUILDIT.md, for example.

I'll open a separate issue (#348) and I'll dig through the history for the most updated version and restore that section in a different PR.

panoramix360 · 2023-08-31T16:46:54Z

If you need any QA testing, just let me know!

nelsonic · 2023-09-04T08:42:41Z

I'm going to remove the list_items schema and code from this PR ref: #413
Then will do the final tasks and this should be QA-able.

…g.html for #145 as per #350

nelsonic · 2023-09-07T10:07:38Z

Documented in: https://dwyl.github.io/book/mvp/16-lists.html and https://dwyl.github.io/book/mvp/18-reordering.html 📝 ✅

nelsonic · 2023-09-07T10:08:22Z

Going to resolve these merge-conflicts quick:

nelsonic · 2023-09-07T10:09:56Z

GitHub with all it's AI superpowers still hasn't figured out how to auto-resolve merge conflicts and is reporting them incorrectly:

nelsonic · 2023-09-07T10:23:46Z

I'm not "happy" with the code. There are quite a few inconsistencies in event and variable names. 😕
Specifically the use of both camel case "dragoverItem" and snake case "move_items" and in the app.js file there are even hyphen even names: "remove-highlight" ... I've opened an issue to tidy this code: #416

But since we've waited way too long for the reordering feature I'm not going to do tidy up now. ⏳
Please feel free to pick this up. 🙏

nelsonic

This feature is working. ✅
The migrations are non-destructive and can be rolled-back if needed. 🎢
Let's get @iteles to QA it in prod! 👩‍💻
Ship.

nelsonic · 2023-09-08T03:57:07Z

Obvs there was an issue: #417
I'm looking at it now.
But clearly nobody else is using the MVP as their "daily driver" Todo List (yet) as nobody has "complained" about it.

LuchoTurtle · 2023-09-08T13:26:35Z

I actually noticed the issue yesterday but didn't raise any issue because, as you've stated, you had created it already over at #417, so I figured there was no point in duplicating 🤷

LuchoTurtle added 2 commits March 30, 2023 14:22

feat: Adding position field and functions to change the position afte…

7d5a8be

…r adding a new item. #145

feat: Trying to get the highlight to work on the client of Phoenix. #145

9b1a7f5

LuchoTurtle added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! in-progress An issue or pull request that is being worked on by the assigned person labels Mar 31, 2023

LuchoTurtle added 8 commits March 31, 2023 12:06

fix: Fixing sorting on the client side. #145

a4ab130

feat: Switching positions between items is now persisted in the datab…

5a4a5f3

…ase. #145

fix: Tags are part of the <li> so they can be dragged as well. #145

492478c

fix: Undefined IDs don't create updateIndexes event. #145

21cc6e5

feat: Adding tests. Coverage back to 100%. #145

aa75dcc

feat: Add dot lines. #145

2c44131

fix: Renaming events. #145

35a6b05

fix: Mix format. #145

6ce28fb

LuchoTurtle added 4 commits April 4, 2023 13:04

feat: Add section on build it. #145

e1d4610

fix: Fixing typos. #145

83cc8d2

fix: Running mix format.

eee8d49

Merge branch 'main' into drag-drop_fix#145

7c0a29c

LuchoTurtle marked this pull request as ready for review April 4, 2023 12:21

LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Apr 4, 2023

LuchoTurtle assigned nelsonic Apr 4, 2023

nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Apr 9, 2023

LuchoTurtle mentioned this pull request Apr 9, 2023

[Chore] Missing Stats Page sections in BUILDIT.md file #348

Closed

remove list_items schema while maintaining all functionality #413

39a758c

nelsonic mentioned this pull request Sep 5, 2023

Chore: Remove list_items schema #413

Closed

4 tasks

nelsonic added 4 commits September 7, 2023 10:35

shift reordering docs to https://dwyl.github.io/book/mvp/18-reorderin…

80c81c3

…g.html for #145 as per #350

rename updateIndexes to update_list_seq for clarity #145

36f85c6

remove debug code from lib/app_web/live/app_live.html.heex #145

4d45753

Fix numbering in BUILDIT.md #145

fcb45fd

nelsonic added the merge-conflicts The branch or pull request has merge conflicts with the target branch (e.g. master) label Sep 7, 2023

nelsonic and others added 3 commits September 7, 2023 11:11

Merge branch 'main' into drag-drop_fix#145

102aaa6

add test for update_list_seq/3 #145

bce6945

invoke App.Person.get_person_id from #415

a7408a1

nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed merge-conflicts The branch or pull request has merge conflicts with the target branch (e.g. master) in-progress An issue or pull request that is being worked on by the assigned person labels Sep 7, 2023

nelsonic added 2 commits September 7, 2023 11:28

remove remaining dbg code #145

630255e

remove more debug code ... #145

6362525

nelsonic approved these changes Sep 7, 2023

View reviewed changes

nelsonic merged commit b8aee0e into main Sep 7, 2023
3 checks passed

nelsonic deleted the drag-drop_fix#145 branch September 7, 2023 10:39

This was referenced Sep 7, 2023

PR: Lists #165

Merged

Chore Add all existing items to “all” list #417

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PR] Adding drag n drop and index-based reordering #345

[PR] Adding drag n drop and index-based reordering #345

LuchoTurtle commented Mar 31, 2023 •

edited

Loading

codecov bot commented Apr 3, 2023 •

edited

Loading

LuchoTurtle commented Apr 4, 2023

nelsonic commented Apr 9, 2023

LuchoTurtle commented Apr 9, 2023 •

edited

Loading

panoramix360 commented Aug 31, 2023

nelsonic commented Sep 4, 2023

nelsonic commented Sep 7, 2023

nelsonic commented Sep 7, 2023

nelsonic commented Sep 7, 2023

nelsonic commented Sep 7, 2023

nelsonic left a comment

nelsonic commented Sep 8, 2023

LuchoTurtle commented Sep 8, 2023

[PR] Adding drag n drop and index-based reordering #345

[PR] Adding drag n drop and index-based reordering #345

Conversation

LuchoTurtle commented Mar 31, 2023 • edited Loading

codecov bot commented Apr 3, 2023 • edited Loading

Codecov Report

LuchoTurtle commented Apr 4, 2023

nelsonic commented Apr 9, 2023

🤷‍♂️

LuchoTurtle commented Apr 9, 2023 • edited Loading

panoramix360 commented Aug 31, 2023

nelsonic commented Sep 4, 2023

nelsonic commented Sep 7, 2023

nelsonic commented Sep 7, 2023

nelsonic commented Sep 7, 2023

nelsonic commented Sep 7, 2023

nelsonic left a comment

Choose a reason for hiding this comment

nelsonic commented Sep 8, 2023

LuchoTurtle commented Sep 8, 2023

LuchoTurtle commented Mar 31, 2023 •

edited

Loading

codecov bot commented Apr 3, 2023 •

edited

Loading

LuchoTurtle commented Apr 9, 2023 •

edited

Loading